Merged
Conversation
dancastillo
reviewed
Jan 5, 2025
Co-authored-by: Dan Castillo <[email protected]> Signed-off-by: Matteo Pietro Dazzi <[email protected]>
This was referenced Jan 6, 2025
simoneb
reviewed
Jan 8, 2025
dancastillo
reviewed
Jan 9, 2025
Member
dancastillo
left a comment
dancastillo
left a comment
There was a problem hiding this comment.
Looks good, I would just updated the coverage check and add --check-coverage --lines 100 to test:unit and coverage to ensure it maintains coverage
Co-authored-by: Dan Castillo <[email protected]> Signed-off-by: Matteo Pietro Dazzi <[email protected]>
Co-authored-by: Dan Castillo <[email protected]> Signed-off-by: Matteo Pietro Dazzi <[email protected]>
Fdawgs
requested changes
Jan 10, 2025
Member
Fdawgs
left a comment
Fdawgs
left a comment
There was a problem hiding this comment.
c8 has gone missing from the dev dependencies, but is used in the coverage script.
Fdawgs
approved these changes
Jan 10, 2025
4 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
run
npm run testandnpm run benchmarktests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct
Migrated to node test runner
Removed simple-get in favour of fetch