Conversation
Member
|
Is there a reason? |
Contributor
Author
|
the handlebars test does not make any sense, and is more like a handlebars test than a fastify-static test. |
Signed-off-by: Aras Abbasi <[email protected]>
gurgunday
reviewed
Aug 21, 2024
Member
gurgunday
left a comment
gurgunday
left a comment
There was a problem hiding this comment.
I get the test part but the example without a template engine is dangerous as if a file name contains " or a special HTML char, the template in this example would break
Even if it would be fine here, it's not a good practice to show it as an example I think
Contributor
Author
|
Maybe, but even we are not using handlebars in our implementation of fastifystatic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct