fix proxying with double slash#319
Merged
Uzlopak merged 6 commits intofastify:masterfrom Jun 12, 2023
Merged
Conversation
This was referenced Jun 7, 2023
Contributor
Author
|
Hey, could someone please approve running the workflow, the last CI failed due to |
Contributor
Author
|
this is weird, the CI does not run at all due to: is it because of my empty commit? |
Member
|
Even worst, no action triggered. |
climba03003
requested changes
Jun 9, 2023
Member
climba03003
left a comment
climba03003
left a comment
There was a problem hiding this comment.
Prevent unintentional merge since CI broken
Member
|
This should run now? |
Member
|
Can you try again? |
Contributor
Author
|
What to try? Push? |
Uzlopak
reviewed
Jun 10, 2023
Contributor
Author
|
Hey @climba03003 can you please re-review, the actions are runnings |
climba03003
approved these changes
Jun 11, 2023
Contributor
Author
|
let's merge this? |
Uzlopak
reviewed
Jun 11, 2023
Contributor
Author
|
Let's merge it? |
Contributor
Author
|
@mcollina is there something left I need to do? |
Contributor
Author
|
@Uzlopak Thanks, have any estimation for deployment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Fix: