Move @types/jsonwebtoken to dep list#51
Merged
Ethan-Arrowood merged 1 commit intofastify:masterfrom Mar 28, 2019
Merged
Conversation
Member
Author
|
Travis is taking quite a while. I think the builds are still in queue even. Whenever they run and pass I'll merge and update the plugin. What semver change is this? |
Member
|
It’s a patch. Would you mind sending a PR to migrate this to Azure Pipelines? |
Member
Author
|
Will do
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to fix the issue #50 by installing @types/jsonwebtoken as a dependency instead of a devDep. This makes sense as if you're shipping the
index.d.tsand it is referencing types from@types/jsonwebtokenthen you should be shipping those types with the package.