Skip to content

chore: update plugins-ci-elasticsearch.yml reference to v5.0.0#118

Closed
tpreviero wants to merge 1 commit intofastify:masterfrom
tpreviero:update-plugins-ci-elasticsearch-to-v5.0.0
Closed

chore: update plugins-ci-elasticsearch.yml reference to v5.0.0#118
tpreviero wants to merge 1 commit intofastify:masterfrom
tpreviero:update-plugins-ci-elasticsearch-to-v5.0.0

Conversation

@tpreviero
Copy link
Copy Markdown
Contributor

@tpreviero tpreviero commented Sep 27, 2024 •
edited
Loading

Updates plugins-ci-elasticsearch.yml to version v5.0.0.

Checklist

@tpreviero tpreviero mentioned this pull request Sep 27, 2024
Merged
4 tasks
dancastillo
dancastillo approved these changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gurgunday
gurgunday requested changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to look at this but CI is red

@tpreviero
Copy link
Copy Markdown
Contributor Author

tpreviero commented Sep 27, 2024

I was going to look at this but CI is red

Apparently the image elasticsearch:8.13.2, which is the one being currently used, is not present on Docker Hub.
We would need to update that docker image version.

@tpreviero tpreviero mentioned this pull request Sep 27, 2024
Merged
4 tasks
@tpreviero
Copy link
Copy Markdown
Contributor Author

tpreviero commented Sep 27, 2024

I was going to look at this but CI is red

Apparently the image elasticsearch:8.13.2, which is the one being currently used, is not present on Docker Hub. We would need to update that docker image version.

Opened fastify/workflows#136 to tackle this.

@tpreviero
Copy link
Copy Markdown
Contributor Author

tpreviero commented Sep 28, 2024

As v5.0.0 version of https://github.com/fastify/workflows contains an elasticsearch image version that is not on Docker Hub, closing this in favour of #119.

@tpreviero tpreviero closed this Sep 28, 2024
@tpreviero tpreviero mentioned this pull request Sep 28, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gurgunday gurgunday gurgunday requested changes

@dancastillo dancastillo dancastillo approved these changes

@climba03003 climba03003 climba03003 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tpreviero @dancastillo @climba03003 @gurgunday