Conversation
mcollina
left a comment
There was a problem hiding this comment.
Seem to work great! Just a note!
Co-authored-by: Matteo Collina <[email protected]>
|
There was an error on the coverage step that requires the Now the error is the following: Not sure the config required to get the coverrals working. |
|
I would just remove coveralls from everywhere. |
I think I talked about this with @mcollina early last year when I was trying to standardise the plugin repos. Some of the repos in the Fastify org do not send coverage to Coveralls or fail to do so if they try (like this one). Fastify-cors is an example of one that does manage to send coverage. If the repo is missing a coveralls badge in the readme then it's one that will most likely fail. |
|
I would just disable it everywhere, it's not worth it (effort vs the information it provides). |
|
+1 on disabling coveralls if it's a blocker for this feature |
|
@Eomm, v2 of workflows has been released, which has removed all coveralls integration. |
.github/workflows/ci.yml
Outdated
| @@ -1,45 +1,15 @@ | |||
| name: ci | |||
| 'on': | |||
| name: CI | |||
There was a problem hiding this comment.
The CI badge in the readme may need to be updated if changing from lower to uppercase, but i prefer the uppercase to be honest!
There was a problem hiding this comment.
Good spot: for consistency in the action menu, I would keep the old ci name.
I must say that I like the upper case too 😖
|
LGTM 👍 |
Testing the new reusable workflow