Skip to content

fix: add http method override warning - #6879

Merged
jean-michelet merged 4 commits into
mainfrom
fix/add-http-method-override-warning
Jul 30, 2026
Merged

jean-michelet merged 4 commits into
mainfrom
fix/add-http-method-override-warning

Conversation

@jean-michelet

@jean-michelet jean-michelet commented Jul 29, 2026 •

Copy link
Copy Markdown
Member

Fixes #6284.

This supersedes #6608 because the original contributor has not responded to the latest review feedback.
I would like to publish this deprecation at least a few weeks before the Fastify v6 release.

This change:

  • Emits FSTDEP025 when addHttpMethod overrides an existing method implicitly.
  • Adds overrideExisting: true to make the override explicit and suppress the warning.
  • Documents that implicit overrides will throw in v6.

@github-actions github-actions Bot added documentation Improvements or additions to documentation typescript TypeScript related labels Jul 29, 2026
@jean-michelet jean-michelet changed the title Fix/add http method override warning fix: add http method override warning Jul 29, 2026
@jean-michelet
jean-michelet requested a review from a team July 29, 2026 11:23
Comment thread lib/warnings.js Resolved
@jean-michelet
jean-michelet merged commit 0e9a3b3 into main Jul 30, 2026
43 checks passed
@jean-michelet
jean-michelet deleted the fix/add-http-method-override-warning branch July 30, 2026 10:00
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation typescript TypeScript related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

addHttpMethod override existing http standard methods

3 participants