Skip to content

docs: specific warning suppression - #6871

Merged
Eomm merged 9 commits into
mainfrom
docs/specific-warning-suppression
Jul 29, 2026
Merged

Eomm merged 9 commits into
mainfrom
docs/specific-warning-suppression

Conversation

@jean-michelet

@jean-michelet jean-michelet commented Jul 24, 2026 •

Copy link
Copy Markdown
Member

Curious that this is still on Stability 1.1 after many years?

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 24, 2026
@jean-michelet
jean-michelet requested review from a team, Eomm and climba03003 and removed request for Eomm and climba03003 July 24, 2026 14:56
ilteoood
ilteoood previously approved these changes Jul 25, 2026

@jsumners jsumners left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember if we intentionally kept the documentation here brief or not. I think the brevity forces people to read the upstream documentation and also imparts that we don't really think folks should be doing this.

That last point is what has me on the fence about this. The more we tell people how to turn off the warnings, the less likely they are to heed them. My inclination is to say we shouldn't point out this new flag at all and if someone figures out the possibility from their knowledge of core, so be it.

But the short text proposed is otherwise fine.

Comment thread docs/Reference/Warnings.md Resolved
@jean-michelet

Copy link
Copy Markdown
Member Author

My inclination is to say we shouldn't point out this new flag at all and if someone figures out the possibility from their knowledge of core, so be it.

I think this is somewhat controversial, not a clear consensus on this:

Like you I am very defensive, but only as a default, users should have the liberty at the end of the day

My concern is why the approved flag is still marked Stability: 1.1 Active development.
Screenshot from 2026-07-25 16-57-50

cc @Ethan-Arrowood, any update on this?

@climba03003

Copy link
Copy Markdown
Member

Curious that this is still on Stability 1.1 after many years?

Little people interested in further development.
Most people satisfy with current usage.
No one pushing the status further because more interested (valuable) task is before it.

I believe it just need volunteer to push the status.

jsumners
jsumners previously approved these changes Jul 25, 2026
@jean-michelet

Copy link
Copy Markdown
Member Author

@jsumners I am pushing a doc update to Node core, I recommend we wait their answer.

Comment thread docs/Reference/Warnings.md Resolved
Co-authored-by: Manuel Spigolon <[email protected]>
Signed-off-by: Jean Michelet <[email protected]>
Eomm
Eomm previously approved these changes Jul 27, 2026
@jean-michelet

Copy link
Copy Markdown
Member Author

I removed the note because nodejs/node#64742 has been merged, so we can consider it stable.

@Eomm
Eomm enabled auto-merge (squash) July 29, 2026 06:48
@Eomm
Eomm merged commit 812608e into main Jul 29, 2026
9 checks passed
@Eomm
Eomm deleted the docs/specific-warning-suppression branch July 29, 2026 07:29
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants