chore: update depedabot setting#6715
Conversation
jsumners
left a comment
There was a problem hiding this comment.
I am glad to see that I will still get @fastify/leads notifications.
I will not block this, but I am completely opposed to Dependabot full stop. I think this is a better configuration, but I am confident it will cause problems outside of the noise no one is paying attention to. Namely, modules ship new majors to go ESM only, and that is incompatible with the framework. Again, bumping the major of a "production" dependency is itself a major version action.
ESM only never an issues now, since
I still prefer it as a notification for us to keep the dependencies up-to-date. |
Same, I like the notifications, saves us having to go and manually find any dependency with a major update. In regards to the automerge action, we need to change these https://github.com/search?q=org%3Afastify+%22target%3A+major%22&type=code to |
|
The last thing I will add is the link I included in the issue I opened and closed on this topic: https://github.com/search?q=org%3Afastify+dependabot+state%3Aopen&type=pullrequests That should have zero items if this tool were providing value. |
89ec338 to
f8d1b50
Compare
Most of the PR spam about |
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce necessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]> Co-authored-by: Antonio Tripodi <[email protected]>
Update dependabot setting to reduce necessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce unnecessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Update dependabot setting to reduce necessary change and noise. Ref fastify/fastify#6715 Signed-off-by: KaKa <[email protected]>
Proposed to update the dependabot configuration as follow.
The proposed change should address the issues.
There is no meaning to restrict a monthly check since we allows only
major.At most delay the landing about 14 days.
I assume it can reduce the number of PR to around "2-3 (each repository) a year" and most of them would be Github Actions updates.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct