types: Allow port to be null in request type definition#6589
Merged
jean-michelet merged 2 commits intofastify:mainfrom Mar 17, 2026
Merged
types: Allow port to be null in request type definition#6589jean-michelet merged 2 commits intofastify:mainfrom
jean-michelet merged 2 commits intofastify:mainfrom
Conversation
Signed-off-by: Tristan Barlow-Griffin <[email protected]>
jean-michelet
approved these changes
Mar 16, 2026
Member
jean-michelet
left a comment
jean-michelet
left a comment
There was a problem hiding this comment.
This may break some CIs. But type level changes are not covered by our breaking change policy.
Member
|
Sorry, I forgot to run the CI. |
Contributor
Author
@jean-michelet thank you for reviewing and my apologies for the failing test, I did not realise there are type tests. |
jean-michelet
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing in an environment where the connection does not contain an explicit port number the req.port value is null. This I believe is due to a fallback value of null that can be seen here:
fastify/lib/request.js
Line 261 in b5172f6
This PR corrects the port type to represent that the value can be null.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct