ci(link-checker): fix root-relative links resolution#6535
Merged
climba03003 merged 3 commits intofastify:mainfrom Mar 10, 2026
Merged
ci(link-checker): fix root-relative links resolution#6535climba03003 merged 3 commits intofastify:mainfrom
climba03003 merged 3 commits intofastify:mainfrom
Conversation
Eomm
requested changes
Mar 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the internal markdown link-check workflow to correctly resolve root-relative local paths (e.g. /docs/...) by providing Lychee a repository root directory during CI runs.
Changes:
- Add
--root-dir .to Lychee CLI args in the GitHub Actions link-check workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
climba03003
requested changes
Mar 8, 2026
Signed-off-by: KaKa <[email protected]>
climba03003
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6522
Summary
The link checker was failing to resolve root-relative links such as:
/docs/Reference/TypeScript.md
This happens because lychee requires the
--root-diroption to correctly resolve local root-relative paths.Changes
Added
--root-dir .to the lychee arguments in the GitHub Actions workflow.Result
This fixes false positives from the link checker when running locally and in CI, without affecting runtime code.