Skip to content

docs: replace all instances of twitter.com with x.com#6355

Merged
Eomm merged 1 commit intofastify:mainfrom
cseas:chore-twitter-links
Nov 10, 2025
Merged

docs: replace all instances of twitter.com with x.com#6355
Eomm merged 1 commit intofastify:mainfrom
cseas:chore-twitter-links

Conversation

@cseas
Copy link
Copy Markdown
Contributor

@cseas cseas commented Oct 6, 2025 •
edited
Loading

Replaced outdated twitter links

Checklist

jsumners
jsumners reviewed Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the links are still valid. I don't know of a single person that calls that site by the rename. If the links don't work, sure; but I bet they do.

@cseas
Copy link
Copy Markdown
Contributor Author

cseas commented Oct 7, 2025

In my opinion, the links are still valid. I don't know of a single person that calls that site by the rename. If the links don't work, sure; but I bet they do.

Correct, the links are valid but they all redirect to x.com now. This is just a housekeeping PR to avoid the redirect.
Feel free to close if not needed.

jean-michelet
jean-michelet reviewed Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jean-michelet jean-michelet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with the changes, but yes, the current links will probably remains valid for legacy.

@Eomm Eomm added the documentation Improvements or additions to documentation label Oct 7, 2025
@Uzlopak
Copy link
Copy Markdown
Contributor

Uzlopak commented Oct 7, 2025

Maybe removing twitter/x is better?

@jean-michelet
Copy link
Copy Markdown
Member

jean-michelet commented Oct 7, 2025

Maybe removing twitter/x is better?

Yep, people can redirect to their social networks from their Github profile.

@Fdawgs Fdawgs changed the title chore: replace all instances of twitter.com with x.com docs: replace all instances of twitter.com with x.com Oct 8, 2025
@Fdawgs
Copy link
Copy Markdown
Member

Fdawgs commented Nov 10, 2025

Maybe removing twitter/x is better?

@fastify/core thoughts?

gurgunday
gurgunday approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm neutral but let's merge this anyway while discussing it, twitter domain might be retired soon

@Eomm Eomm mentioned this pull request Nov 10, 2025
Closed
@Eomm Eomm merged commit 27e3fe3 into fastify:main Nov 10, 2025
10 checks passed
@cseas cseas deleted the chore-twitter-links branch November 26, 2025 06:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jsumners jsumners jsumners left review comments

@jean-michelet jean-michelet jean-michelet left review comments

@Eomm Eomm Eomm approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cseas @Uzlopak @jean-michelet @Fdawgs @jsumners @Eomm @gurgunday