ci: improve citgm workflows#6334
Merged
Merged
Conversation
kibertoad
reviewed
Sep 25, 2025
kibertoad
reviewed
Sep 25, 2025
kibertoad
approved these changes
Sep 25, 2025
jean-michelet
pushed a commit
to jean-michelet/fastify
that referenced
this pull request
Sep 27, 2025
… error-parameter for setErrorHandler and errorHandler to unknown, but configurable via generic TError (fastify#6308) * types: loosen setErrorHandler and errorHandler types * set TError to unknown add generic to errorHandler * fix * remove obsolte type tst * add unit test, fix potential issue --------- Co-authored-by: Jean <[email protected]> build(deps-dev): remove @fastify/pre-commit (fastify#6319) `@fastify/pre-commit` isn't configured or used in this repo as there is no `pre-commit` object in package.json. It won't run regardless as scripts are disabled. Signed-off-by: Frazer Smith <[email protected]> Co-authored-by: Aras Abbasi <[email protected]> ci: improve citgm workflows (fastify#6334) * ci: improve citgm workflows * fix remark docs: explain stream error handling (fastify#5746) * docs: explain stream error handling * Update docs/Reference/Server.md Co-authored-by: Matteo Collina <[email protected]> Signed-off-by: James Sumners <[email protected]> * Apply suggestions from code review Co-authored-by: Frazer Smith <[email protected]> Signed-off-by: Denys Otrishko <[email protected]> * docs: explain stream error handling * fix test --------- Signed-off-by: James Sumners <[email protected]> Signed-off-by: Denys Otrishko <[email protected]> Signed-off-by: Aras Abbasi <[email protected]> Co-authored-by: James Sumners <[email protected]> Co-authored-by: Matteo Collina <[email protected]> Co-authored-by: Frazer Smith <[email protected]> Co-authored-by: Aras Abbasi <[email protected]> fix: error throwing in reply (fastify#6299) * fix: instantiate readable stream error * Create reply-web-stream-locked.test.js Signed-off-by: Juan L. <[email protected]> Signed-off-by: Juan Letamendia <[email protected]> * fix test --------- Signed-off-by: Juan L. <[email protected]> Signed-off-by: Juan Letamendia <[email protected]> Co-authored-by: Aras Abbasi <[email protected]> docs: create 2 frst chapters of the tutorial docs: nit docs: create a fastify server docs: create basic routes docs: improve chapter 4 refactor: improve readability and quote examples docs: decoration chapter public part docs: decoration chapter public part fix: typo fix: typo fix: markdown lint docs: document internals docs: validatio nand serialization docs: move section mapping reminder with routes declarations docs: add hooks chapter docs: remove internals involved sections docs: add error handling chapter fix: copilot suggestions
jean-michelet
pushed a commit
to jean-michelet/fastify
that referenced
this pull request
Sep 27, 2025
… error-parameter for setErrorHandler and errorHandler to unknown, but configurable via generic TError (fastify#6308) * types: loosen setErrorHandler and errorHandler types * set TError to unknown add generic to errorHandler * fix * remove obsolte type tst * add unit test, fix potential issue --------- Co-authored-by: Jean <[email protected]> build(deps-dev): remove @fastify/pre-commit (fastify#6319) `@fastify/pre-commit` isn't configured or used in this repo as there is no `pre-commit` object in package.json. It won't run regardless as scripts are disabled. Signed-off-by: Frazer Smith <[email protected]> Co-authored-by: Aras Abbasi <[email protected]> ci: improve citgm workflows (fastify#6334) * ci: improve citgm workflows * fix remark docs: explain stream error handling (fastify#5746) * docs: explain stream error handling * Update docs/Reference/Server.md Co-authored-by: Matteo Collina <[email protected]> Signed-off-by: James Sumners <[email protected]> * Apply suggestions from code review Co-authored-by: Frazer Smith <[email protected]> Signed-off-by: Denys Otrishko <[email protected]> * docs: explain stream error handling * fix test --------- Signed-off-by: James Sumners <[email protected]> Signed-off-by: Denys Otrishko <[email protected]> Signed-off-by: Aras Abbasi <[email protected]> Co-authored-by: James Sumners <[email protected]> Co-authored-by: Matteo Collina <[email protected]> Co-authored-by: Frazer Smith <[email protected]> Co-authored-by: Aras Abbasi <[email protected]> fix: error throwing in reply (fastify#6299) * fix: instantiate readable stream error * Create reply-web-stream-locked.test.js Signed-off-by: Juan L. <[email protected]> Signed-off-by: Juan Letamendia <[email protected]> * fix test --------- Signed-off-by: Juan L. <[email protected]> Signed-off-by: Juan Letamendia <[email protected]> Co-authored-by: Aras Abbasi <[email protected]> docs: create 2 frst chapters of the tutorial docs: nit docs: create a fastify server docs: create basic routes docs: improve chapter 4 refactor: improve readability and quote examples docs: decoration chapter public part docs: decoration chapter public part fix: typo fix: typo fix: markdown lint docs: document internals docs: validatio nand serialization docs: move section mapping reminder with routes declarations docs: add hooks chapter docs: remove internals involved sections docs: add error handling chapter fix: copilot suggestions
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The citgm workflow works suboptimal.
Packages which use typescript can get typing errors which can be found in installed dev dependences when fastify is installed with
npm i. So for fastify we install dependencies with--production.CITGM uses node 20. I changed it to node 24.
the citgm workflow is only triggerable by adding the correct label. I added workflow_dispatch as trigger, so we can run the workflow also without a PR.
The label is not removed after the citgm pipeline failed. Added always() into the if-condition to run the job even if the citgm job failed.
citgm-package workflow is now more elegant when you want to trigger the workflow manually. You select the plugin, node version and operating system in drop downs.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct