Skip to content

build(deps-dev): remove @fastify/pre-commit#6319

Merged
Uzlopak merged 2 commits into
mainfrom
build/pre-commit
Sep 25, 2025
Merged

build(deps-dev): remove @fastify/pre-commit#6319
Uzlopak merged 2 commits into
mainfrom
build/pre-commit

Conversation

@Fdawgs

@Fdawgs Fdawgs commented Sep 17, 2025

Copy link
Copy Markdown
Member

@fastify/pre-commit isn't configured or used in this repo as there is no pre-commit object in package.json. It won't run regardless as scripts are disabled.

See fastify/deepmerge#78

Checklist

`@fastify/pre-commit` isn't configured or used in this repo as there is no `pre-commit` object in package.json. It won't run regardless as scripts are disabled.

Signed-off-by: Frazer Smith <[email protected]>

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fdawgs if there is no precommit configuration in package.json than afaik only "test' script will be run.

@Uzlopak

Uzlopak commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

@metcoder95 What a sick joke... Macos 20 is failing...

@metcoder95

Copy link
Copy Markdown
Member

@Uzlopak MacOs has become your nemesis

@Uzlopak Uzlopak changed the title build(deps-dev): remove @fastify/pre-commit invalid: remove @fastify/pre-commit Sep 18, 2025
@Uzlopak Uzlopak changed the title invalid: remove @fastify/pre-commit build(deps-dev): remove @fastify/pre-commit Sep 18, 2025
This was referenced Sep 21, 2025
This was referenced Sep 21, 2025
@Uzlopak Uzlopak merged commit da642ab into main Sep 25, 2025
27 of 34 checks passed
@Uzlopak Uzlopak deleted the build/pre-commit branch September 25, 2025 22:25
jean-michelet pushed a commit to jean-michelet/fastify that referenced this pull request Sep 27, 2025
… error-parameter for setErrorHandler and errorHandler to unknown, but configurable via generic TError (fastify#6308)

* types: loosen setErrorHandler and errorHandler types

* set TError to unknown
add generic to errorHandler

* fix

* remove obsolte type tst

* add unit test, fix potential issue

---------

Co-authored-by: Jean <[email protected]>

build(deps-dev): remove @fastify/pre-commit (fastify#6319)

`@fastify/pre-commit` isn't configured or used in this repo as there is no `pre-commit` object in package.json. It won't run regardless as scripts are disabled.

Signed-off-by: Frazer Smith <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

ci: improve citgm workflows (fastify#6334)

* ci: improve citgm workflows

* fix remark

docs: explain stream error handling (fastify#5746)

* docs: explain stream error handling

* Update docs/Reference/Server.md

Co-authored-by: Matteo Collina <[email protected]>
Signed-off-by: James Sumners <[email protected]>

* Apply suggestions from code review

Co-authored-by: Frazer Smith <[email protected]>
Signed-off-by: Denys Otrishko <[email protected]>

* docs: explain stream error handling

* fix test

---------

Signed-off-by: James Sumners <[email protected]>
Signed-off-by: Denys Otrishko <[email protected]>
Signed-off-by: Aras Abbasi <[email protected]>
Co-authored-by: James Sumners <[email protected]>
Co-authored-by: Matteo Collina <[email protected]>
Co-authored-by: Frazer Smith <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

fix: error throwing in reply (fastify#6299)

* fix: instantiate readable stream error

* Create reply-web-stream-locked.test.js

Signed-off-by: Juan L. <[email protected]>
Signed-off-by: Juan Letamendia <[email protected]>

* fix test

---------

Signed-off-by: Juan L. <[email protected]>
Signed-off-by: Juan Letamendia <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

docs: create 2 frst chapters of the tutorial

docs: nit

docs: create a fastify server

docs: create basic  routes

docs: improve chapter 4

refactor: improve readability and quote examples

docs: decoration chapter public part

docs: decoration chapter public part

fix: typo

fix: typo

fix: markdown lint

docs: document internals

docs: validatio nand serialization

docs: move section mapping reminder with routes declarations

docs: add hooks chapter

docs: remove internals involved sections

docs: add error handling chapter

fix: copilot suggestions
jean-michelet pushed a commit to jean-michelet/fastify that referenced this pull request Sep 27, 2025
… error-parameter for setErrorHandler and errorHandler to unknown, but configurable via generic TError (fastify#6308)

* types: loosen setErrorHandler and errorHandler types

* set TError to unknown
add generic to errorHandler

* fix

* remove obsolte type tst

* add unit test, fix potential issue

---------

Co-authored-by: Jean <[email protected]>

build(deps-dev): remove @fastify/pre-commit (fastify#6319)

`@fastify/pre-commit` isn't configured or used in this repo as there is no `pre-commit` object in package.json. It won't run regardless as scripts are disabled.

Signed-off-by: Frazer Smith <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

ci: improve citgm workflows (fastify#6334)

* ci: improve citgm workflows

* fix remark

docs: explain stream error handling (fastify#5746)

* docs: explain stream error handling

* Update docs/Reference/Server.md

Co-authored-by: Matteo Collina <[email protected]>
Signed-off-by: James Sumners <[email protected]>

* Apply suggestions from code review

Co-authored-by: Frazer Smith <[email protected]>
Signed-off-by: Denys Otrishko <[email protected]>

* docs: explain stream error handling

* fix test

---------

Signed-off-by: James Sumners <[email protected]>
Signed-off-by: Denys Otrishko <[email protected]>
Signed-off-by: Aras Abbasi <[email protected]>
Co-authored-by: James Sumners <[email protected]>
Co-authored-by: Matteo Collina <[email protected]>
Co-authored-by: Frazer Smith <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

fix: error throwing in reply (fastify#6299)

* fix: instantiate readable stream error

* Create reply-web-stream-locked.test.js

Signed-off-by: Juan L. <[email protected]>
Signed-off-by: Juan Letamendia <[email protected]>

* fix test

---------

Signed-off-by: Juan L. <[email protected]>
Signed-off-by: Juan Letamendia <[email protected]>
Co-authored-by: Aras Abbasi <[email protected]>

docs: create 2 frst chapters of the tutorial

docs: nit

docs: create a fastify server

docs: create basic  routes

docs: improve chapter 4

refactor: improve readability and quote examples

docs: decoration chapter public part

docs: decoration chapter public part

fix: typo

fix: typo

fix: markdown lint

docs: document internals

docs: validatio nand serialization

docs: move section mapping reminder with routes declarations

docs: add hooks chapter

docs: remove internals involved sections

docs: add error handling chapter

fix: copilot suggestions
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants