feat(types): router option types #6282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Because typing is used in two files, maybe we can export a type from fastify.d.ts: export interface RouterOptions {
allowUnsafeRegex?: boolean,
buildPrettyMeta?: (route: { [k: string]: unknown, store: { [k: string]: unknown } }) => object,
caseSensitive?: boolean,
constraints?: {
[name: string]: ConstraintStrategy<FindMyWayVersion<RawServer>, unknown>,
},
defaultRoute?: (req: FastifyRequest, res: FastifyReply) => void,
ignoreDuplicateSlashes?: boolean,
ignoreTrailingSlash?: boolean,
maxParamLength?: number,
onBadUrl?: (path: string, req: FastifyRequest, res: FastifyReply) => void,
querystringParser?: (str: string) => { [key: string]: unknown },
useSemicolonDelimiter?: boolean,
} |
Member
|
The typescript tests are failing |
Member
Author
|
Looks like typescript tests are failing because Should we update fastify to use |
Member
|
@dancastillo can you fix the problem in a separate PR if you're free? 🙏 |
gurgunday
approved these changes
Aug 11, 2025
Member
Author
|
@gurgunday of course here is PR #6286 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
@mcollina @gurgunday the typescripts tests are now passing |
2 tasks
Contributor
|
Is it possible to release a new version including this change? This should have been included in v5.5.0, as for now we get this deprecation message:
And we can't do nothing about it, as TypeScript will get mad. Thanks! |
3 tasks
2 tasks
1 task
KATT
pushed a commit
to trpc/trpc
that referenced
this pull request
Oct 25, 2025
Since Fastify v5.5.0, there is the following deprecation warning: > [FSTDPE022] FastifyWarning: The router options for maxParamLength property access is deprecated. Please use "options.routerOptions" instead for acce ssing router options. The router options will be removed in `fastify@6`. Related fastify/fastify#6282, fastify/fastify#5985 ## 🎯 Changes Update the Fastify adapter documentation to fix the deprecation warning. Should we put the 2 possible ways for both v5.4 and prior Fastify versions, and for v5.5.0 and above, or it's fine to only put the "latest" way (like how it is done currently in this PR)? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [x] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [x] If necessary, I have added documentation related to the changes made. - [x] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Documentation - Updated Fastify adapter docs to show maxParamLength is now configured under routerOptions (default 5000). - Clarified that server initialization and plugin setup are unchanged. - Confirmed no changes to public APIs and guided users to configure maximum URL parameter lengths in the new location. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
types for #5985
npm run test && npm run benchmark --if-presentand the Code of conduct