Skip to content

ci: ignore scripts#6108

Merged
Uzlopak merged 2 commits intomainfrom
ci/scripts
May 7, 2025
Merged

ci: ignore scripts#6108
Uzlopak merged 2 commits intomainfrom
ci/scripts

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented May 5, 2025

Add the --ignore-scripts arg to disable the execution of any scripts by third-party packages.

See https://snyk.io/blog/npm-security-preventing-supply-chain-attacks/

Checklist

@github-actions github-actions bot added the github actions Github actions related label May 5, 2025
Copy link
Copy Markdown
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:O we were not doing it everywhere.

We should add it to the .npmrc file so we don't must remember to do it on the next npm install script:

ignore-scripts=true

(the arg must stay for other package manages I think)

Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 8318d01 into main May 7, 2025
28 checks passed
@Uzlopak Uzlopak deleted the ci/scripts branch May 7, 2025 11:53
jean-michelet pushed a commit to jean-michelet/fastify that referenced this pull request May 13, 2025
* ci: ignore scripts

* chore(.npmrc): ignore scripts
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

github actions Github actions related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants