Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the testing framework from Tap to Node’s built-in test runner while updating assertion methods and teardown procedures.
- Update import statements to use node:test
- Replace Tap’s assertion methods with t.assert.* equivalents
- Transition from t.teardown to t.after for closing Fastify instances
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/reply-trailers.test.js | Migrated tests to node:test syntax and updated assertions and async handling |
| test/reply-error.test.js | Updated error handling tests to use node:test, with adjustments to teardown and assertions |
Member
|
@jean-michelet best to request reviews from groups rather than individuals, for this repo you'd be looking for a review from core ( |
Member
Author
|
Bystander effect |
Fdawgs
approved these changes
May 2, 2025
Eomm
approved these changes
May 11, 2025
jean-michelet
added a commit
to jean-michelet/fastify
that referenced
this pull request
May 13, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.