Merged
Conversation
jean-michelet
commented
Apr 27, 2025
This was referenced Apr 27, 2025
This was referenced Apr 30, 2025
jean-michelet
requested review from
a team and
jsumners
and removed request for
jsumners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the asynchronous hooks from the Tap framework to a custom sequence helper function and updates the async/await tests accordingly.
- Introduces a new sequence helper in test/toolkit.js to orchestrate async steps.
- Updates the async/await test in test/async-await.test.js to utilize the sequence helper and renames the test callback parameter.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/toolkit.js | Added a new sequence helper function for async steps. |
| test/async-await.test.js | Modified async test to use the sequence function and renamed the test callback. |
* ci: ignore scripts * chore(.npmrc): ignore scripts
…efined error handler on an encapsulated context (fastify#6097) * docs: calling setErrorHandler more than once in the same scope will silently override the previous handler * fix: lint markdown * docs: nit * docs: apply convention * docs: apply convention
…ection that app.ready() is waiting for (fastify#6105)
Signed-off-by: Manuel Spigolon <[email protected]>
Signed-off-by: Manuel Spigolon <[email protected]>
Signed-off-by: Manuel Spigolon <[email protected]>
Eomm
approved these changes
May 15, 2025
Member
|
Alternative runtime error - we can merge |
This was referenced Aug 15, 2025
This was referenced Aug 24, 2025
vaernion
pushed a commit
to Arbeidstilsynet/brevgen2
that referenced
this pull request
Dec 3, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [fastify](https://fastify.dev/) ([source](https://github.com/fastify/fastify)) | [`5.3.3` -> `5.4.0`](https://renovatebot.com/diffs/npm/fastify/5.3.3/5.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v5.4.0`](https://github.com/fastify/fastify/releases/tag/v5.4.0) [Compare Source](fastify/fastify@v5.3.3...v5.4.0) #### What's Changed - test: mv routes-\* from tap by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6092 - test: mv skip-reply-send from tap by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6094 - test: mv plugins from tap by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6088 - fix(ci): ignore alternative runtime result by [@​Eomm](https://github.com/Eomm) in fastify/fastify#6125 - test: mv schema-\* from tap by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6093 - test: mv hooks-async from tap by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6084 - fix(types): add missing version to request.routeOptions by [@​inyourtime](https://github.com/inyourtime) in fastify/fastify#6126 - docs: remove fastify-sentry plugin by [@​dnlup](https://github.com/dnlup) in fastify/fastify#6131 - docs: add community plugins disclaimer by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6132 - docs: use cross-platform compatible info emoji by [@​Fdawgs](https://github.com/Fdawgs) in fastify/fastify#6134 - perf: nits in reply.js by [@​Cangit](https://github.com/Cangit) in fastify/fastify#6136 - docs: join core team by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6142 - docs: fix typo in hash.digest function by [@​piotr-cz](https://github.com/piotr-cz) in fastify/fastify#6145 - test: mv hooks from tap by [@​jean-michelet](https://github.com/jean-michelet) in fastify/fastify#6087 - test: improve issue 4959 unit test by [@​Uzlopak](https://github.com/Uzlopak) in fastify/fastify#6147 - chore: Bump markdownlint-cli2 from 0.17.2 to 0.18.1 by [@​dependabot](https://github.com/dependabot) in https://g...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.