-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: move router options to own key #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move router options to own key #5985
Conversation
ad1f097 to
4caa7c0
Compare
9ee81dc to
580fad8
Compare
|
@Eomm @gurgunday @climba03003 - PTAL, updated the PR to handle the new chances since last approval |
climba03003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the build/build-validation.js.
|
My comment is not fully addressed. |
gurgunday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
hey @climba03003 updated the pr ptal |
climba03003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for long delay, LGTM.
Since Fastify v5.5.0, there is the following deprecation warning: > [FSTDPE022] FastifyWarning: The router options for maxParamLength property access is deprecated. Please use "options.routerOptions" instead for acce ssing router options. The router options will be removed in `fastify@6`. Related fastify/fastify#6282, fastify/fastify#5985 ## 🎯 Changes Update the Fastify adapter documentation to fix the deprecation warning. Should we put the 2 possible ways for both v5.4 and prior Fastify versions, and for v5.5.0 and above, or it's fine to only put the "latest" way (like how it is done currently in this PR)? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## ✅ Checklist - [x] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [x] If necessary, I have added documentation related to the changes made. - [x] I have added or updated the tests related to the changes made. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Documentation - Updated Fastify adapter docs to show maxParamLength is now configured under routerOptions (default 5000). - Clarified that server initialization and plugin setup are unchanged. - Confirmed no changes to public APIs and guided users to configure maximum URL parameter lengths in the new location. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Checklist
closes: #3809
npm run testandnpm run benchmarkand the Code of conduct
Benchmark with changes:
Benchmark currently: