Skip to content

Conversation

@dancastillo
Copy link
Member

Checklist

closes: #3809

Benchmark with changes:

Screenshot 2025-02-13 at 9 11 25 PM

Benchmark currently:

Screenshot 2025-02-13 at 9 12 11 PM

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 14, 2025
@dancastillo dancastillo force-pushed the feat-move-router-options-to-own-key branch from ad1f097 to 4caa7c0 Compare March 21, 2025 02:01
@dancastillo dancastillo requested a review from Eomm March 21, 2025 02:05
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Mar 22, 2025
@dancastillo dancastillo requested a review from Eomm March 25, 2025 01:18
@Eomm Eomm requested a review from climba03003 March 30, 2025 10:47
gurgunday
gurgunday previously approved these changes Mar 30, 2025
@dancastillo dancastillo force-pushed the feat-move-router-options-to-own-key branch from 9ee81dc to 580fad8 Compare June 16, 2025 01:13
@dancastillo
Copy link
Member Author

@Eomm @gurgunday @climba03003 - PTAL, updated the PR to handle the new chances since last approval

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the build/build-validation.js.

@metcoder95 metcoder95 requested a review from climba03003 June 23, 2025 06:57
@climba03003
Copy link
Member

My comment is not fully addressed.

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dancastillo
Copy link
Member Author

hey @climba03003 updated the pr ptal

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for long delay, LGTM.

@metcoder95 metcoder95 merged commit 66c191c into fastify:main Aug 3, 2025
32 checks passed
@dancastillo dancastillo mentioned this pull request Aug 9, 2025
3 tasks
KATT pushed a commit to trpc/trpc that referenced this pull request Oct 25, 2025
Since Fastify v5.5.0, there is the following deprecation warning:
> [FSTDPE022] FastifyWarning: The router options for maxParamLength
property access is deprecated. Please use "options.routerOptions"
instead for acce
ssing router options. The router options will be removed in `fastify@6`.

Related fastify/fastify#6282,
fastify/fastify#5985

## 🎯 Changes

Update the Fastify adapter documentation to fix the deprecation warning.

Should we put the 2 possible ways for both v5.4 and prior Fastify
versions, and for v5.5.0 and above, or it's fine to only put the
"latest" way (like how it is done currently in this PR)?

<!--
Note: once you create a Pull request, we will automatically fix
auto-fixable lint issues in your branch
-->

## ✅ Checklist

- [x] I have followed the steps listed in the [Contributing
guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md).
- [x] If necessary, I have added documentation related to the changes
made.
- [x] I have added or updated the tests related to the changes made.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- Documentation
- Updated Fastify adapter docs to show maxParamLength is now configured
under routerOptions (default 5000).
  - Clarified that server initialization and plugin setup are unchanged.
- Confirmed no changes to public APIs and guided users to configure
maximum URL parameter lengths in the new location.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation semver-minor Issue or PR that should land as semver minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move router options to own key

6 participants