Skip to content

test: migrated decorator.test.js from tap to node:test#5957

Merged
jsumners merged 3 commits intofastify:mainfrom
Tony133:test/migrated-decorator-test
May 1, 2025
Merged

test: migrated decorator.test.js from tap to node:test#5957
jsumners merged 3 commits intofastify:mainfrom
Tony133:test/migrated-decorator-test

Conversation

@Tony133
Copy link
Copy Markdown
Member

@Tony133 Tony133 commented Jan 19, 2025

Checklist

Proposal:

  • migrated decorator.test.js from tap to node:test 🔥

Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
Comment thread test/decorator.test.js Outdated
@Eomm Eomm added the test Issue or pr related to our testing infrastructure. label Jan 21, 2025
Comment thread test/decorator.test.js
gurgunday
gurgunday previously approved these changes May 1, 2025
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners jsumners force-pushed the test/migrated-decorator-test branch from 517d724 to 76c78b0 Compare May 1, 2025 09:50
Copy link
Copy Markdown
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few remaining assertions that need to be updated. Please re-run the test suite and review the output.

@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented May 1, 2025

I updated the test by completing the last remaining assertions 😉, see here: f5cc623

@jsumners jsumners force-pushed the test/migrated-decorator-test branch from f5cc623 to 2f456d3 Compare May 1, 2025 21:16
@jsumners jsumners requested a review from gurgunday May 1, 2025 21:23
@jsumners jsumners merged commit 5fd2a3c into fastify:main May 1, 2025
25 checks passed
@Tony133 Tony133 deleted the test/migrated-decorator-test branch January 10, 2026 16:03
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

test Issue or pr related to our testing infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants