Skip to content

refactor: migrate test framework in build module #5683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reidn3r wants to merge 2 commits into from
Closed

refactor: migrate test framework in build module #5683

reidn3r wants to merge 2 commits into from

Conversation

@reidn3r
Copy link
Contributor

@reidn3r reidn3r commented Sep 15, 2024

These change are related to the issue #5555

  • Migrated from tap framework to node:test in fastify build module
  • Ran the tests that i changed and confirmed they passed successfully

mcollina
mcollina requested changes Sep 15, 2024
View reviewed changes
package.json Outdated
{
"name": "Reidner Adnan",
"url": "https://github.com/reidn3r",
"email": "[email protected]"
Copy link
Member

@mcollina mcollina Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. That section of the package.json is left for the collaborators (also listed in the README).

Copy link
Contributor Author

@reidn3r reidn3r Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! I misunderstood. I apologize.

@reidn3r reidn3r requested a review from mcollina September 15, 2024 16:11
@reidn3r
Copy link
Contributor Author

reidn3r commented Sep 17, 2024

@gurgunday could you please review this PR?

gurgunday
gurgunday reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please uninstall tap

Oh I see, I think we’d prefer a complete removal of tap in one PR rather than these incremental changes

@jsumners
Copy link
Member

jsumners commented Sep 23, 2024

please uninstall tap

Oh I see, I think we’d prefer a complete removal of tap in one PR rather than these incremental changes

I think that would be way too much. We should go for incremental updates like this PR is proposing. But we cannot do it with the current way tests are run:

fastify/package.json

Lines 21 to 30 in 7ddced6

"test": "npm run lint && npm run unit && npm run test:typescript",
"test:ci": "npm run unit -- --coverage-report=lcovonly && npm run test:typescript",
"test:report": "npm run lint && npm run unit:report && npm run test:typescript",
"test:validator:integrity": "npm run build:validation && git diff --quiet --ignore-all-space --ignore-blank-lines --ignore-cr-at-eol lib/error-serializer.js && git diff --quiet --ignore-all-space --ignore-blank-lines --ignore-cr-at-eol lib/configValidator.js",
"test:typescript": "tsc test/types/import.ts --noEmit && tsd",
"test:watch": "npm run unit -- --watch --coverage-report=none --reporter=terse",
"unit": "tap",
"unit:junit": "tap-mocha-reporter xunit < out.tap > test/junit-testresults.xml",
"unit:report": "tap --coverage-report=html --coverage-report=cobertura | tee out.tap",
"citgm": "tap --jobs=1 --timeout=120"

I don't think there's a guarantee that using tap as a runner that it will recognize the output and result of node:test based suites. I think that before we can start on gradually migrating tests in this repo, we need to see a PR merged that looks a lot like newrelic/node-newrelic#2387

@jsumners jsumners mentioned this pull request Sep 25, 2024
Merged
3 tasks
@dancastillo dancastillo mentioned this pull request Sep 29, 2024
Merged
3 tasks
@reidn3r reidn3r closed this by deleting the head repository Oct 13, 2024
@jsumners
Copy link
Member

jsumners commented Oct 13, 2024

Why did you close this? #5720 should be merged soon.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gurgunday gurgunday gurgunday left review comments

@mcollina mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidn3r @jsumners @mcollina @gurgunday