Remove old/deprecated code for Fastify v3#1750
Merged
mcollina merged 3 commits intofastify:nextfrom Jul 16, 2019
smartiniOnGitHub:remove-deprecated-code-for-next
Merged
Remove old/deprecated code for Fastify v3#1750mcollina merged 3 commits intofastify:nextfrom smartiniOnGitHub:remove-deprecated-code-for-next
mcollina merged 3 commits intofastify:nextfrom
smartiniOnGitHub:remove-deprecated-code-for-next
Conversation
…(it's no more supported)
Member
|
Good work so far! |
Contributor
Author
|
@mcollina all deprecated features (and related warnings) removed now ... I'm not sure still there is something to do in 'logger.js' related to some old behavior of genReqId (but I think nothing more should be removed from there). |
xtx1130
approved these changes
Jul 16, 2019
Eomm
pushed a commit
to Eomm/fastify
that referenced
this pull request
Nov 24, 2019
* remove beforeHandler and related implementation and warnings if used (it's no more supported) * remove basePath and related warnings (no more supported) * remove genReqId and related warnings (no more supported)
This was referenced Dec 9, 2019
Closed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
here you can find changes for issue#1654; other commit will happen during next days ... even to see what CI say.
As always, tell me if there is something to fix/improve in my changes.
Thanks a lot. Bye.
First part (1 of 3 or more):
remove beforeHandler and related implementation and warnings if used (it's no more supported)
Checklist
npm run testandnpm run benchmark