remove travis from next branch#1670
Merged
Eomm merged 4 commits intofastify:nextfrom Jun 1, 2019
Merged
Conversation
Eomm
approved these changes
May 24, 2019
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
Should we remove Travis access to this repository after the merge also?
mcollina
requested changes
May 24, 2019
Member
|
Can you also do a similar PR for v1? |
Member
|
I would like @jsumners to have full access before we land this: #1658 (comment). |
Member
|
Please don't let me hold you up on whatever CI integration. I have personal issues with using the Azure CI product and will likely never again bother trying to login. |
delvedor
reviewed
May 24, 2019
Member
Author
|
#1671 is now solved 👍 |
Member
Author
Ethan-Arrowood
force-pushed
the
remove-travis
branch
from
977a069 to
2068bef
Compare
Ethan-Arrowood
added
the
backport 1.x
Member
Author
|
After CI this is ready to go along with the backport #1685 |
mcollina
requested changes
May 31, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1658
Checklist
npm run testandnpm run benchmark