Conversation
mcollina
reviewed
Mar 9, 2019
| } | ||
|
|
||
| const fastify = Fastify({ serverFactory }) | ||
| const fastify = Fastify({ serverFactory, modifyCoreObjects: false }) |
Member
There was a problem hiding this comment.
Can you please add a comment explaining why we are passing the option?
Member
Author
There was a problem hiding this comment.
You can find it a few lines after :)
jsumners
reviewed
Mar 9, 2019
| }) | ||
| ``` | ||
|
|
||
| Disable this option could help in serverless environments such as Google Cloud Functions, where `ip` and `ips` are not writable properties. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some note related to serverless environments and removed "experimental status" from http2 (it's no longer experimental in Node.js core).
Checklist
npm run testandnpm run benchmark