Skip to content

add fastify-405 plugin#1501

Merged
mcollina merged 1 commit intofastify:masterfrom
Eomm:ecosystem/fastify-405
Mar 2, 2019
Merged

add fastify-405 plugin#1501
mcollina merged 1 commit intofastify:masterfrom
Eomm:ecosystem/fastify-405

Conversation

@Eomm
Copy link
Copy Markdown
Member

@Eomm Eomm commented Mar 2, 2019

Hi, I would like to add my plugin to the ecosystem

This plugin tries to solve issue #917

Checklist

  • run npm run test and npm run benchmark
  • tests the and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Mar 2, 2019

I would just add Travis or another CI system to the module. Good work!

@Eomm
Copy link
Copy Markdown
Member Author

Eomm commented Mar 2, 2019

Good suggestion applied ✌
Thank you 🎉

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 563926f into fastify:master Mar 2, 2019
@delvedor delvedor added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Mar 3, 2019
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants