Skip to content

Add res serializer to docs#1455

Merged
mcollina merged 3 commits intofastify:masterfrom
open-source-explorer:update-docs
Mar 10, 2019
Merged

Add res serializer to docs#1455
mcollina merged 3 commits intofastify:masterfrom
open-source-explorer:update-docs

Conversation

@open-source-explorer
Copy link
Copy Markdown
Contributor

Closes #1316

Add res serializer to docs

@open-source-explorer
Copy link
Copy Markdown
Contributor Author

@mcollina What do you think?

Copy link
Copy Markdown
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this above the line This option will be ignored by any logger other than Pino. describing what it does like:

For example, the response payload can be logged using the approach below

@open-source-explorer
Copy link
Copy Markdown
Contributor Author

@cemremengu hope it's fine now 👍

Copy link
Copy Markdown
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/Logging.md Outdated
Comment thread docs/Logging.md
Comment thread docs/Logging.md Outdated
Comment thread docs/Logging.md Outdated
@delvedor delvedor added the documentation Improvements or additions to documentation label Feb 26, 2019
@mcollina
Copy link
Copy Markdown
Member

mcollina commented Mar 8, 2019

@open-source-explorer would you be able to address the requested changes?

@open-source-explorer
Copy link
Copy Markdown
Contributor Author

@mcollina What do you think now?

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants