Skip to content

after should not cause inject() to be called#1132

Merged
mcollina merged 1 commit intomasterfrom
added-test-for-error-before-inject
Sep 4, 2018
Merged

after should not cause inject() to be called#1132
mcollina merged 1 commit intomasterfrom
added-test-for-error-before-inject

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Sep 4, 2018

This was fixed by fastify/avvio#74.

Should we also update the docs about calling after() without a error parameter?

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@mcollina mcollina requested a review from delvedor September 4, 2018 08:15
Copy link
Copy Markdown
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the internals Change that won't impact the surface API. label Sep 4, 2018
@mcollina mcollina merged commit 6d302a5 into master Sep 4, 2018
@delvedor delvedor deleted the added-test-for-error-before-inject branch September 4, 2018 08:56
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

internals Change that won't impact the surface API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants