fastify-apollo has been merged into apollo-server#1126
fastify-apollo has been merged into apollo-server#1126dtex wants to merge 1 commit intofastify:masterfrom dtex:fastify-apollo-snip
Conversation
As of [this PR](apollographql/apollo-server#1013), fastify-apollo is no longer a standalone module and the repo has been archived. @nfishe Can you add a note on your repo also? It would be helpful for anyone who stumbles across it.
|
Awesome! I'll merge this once that is released, is that ok? https://www.npmjs.com/package/apollo-server-fastify is still 10 months old. |
delvedor
left a comment
There was a problem hiding this comment.
I think we can leave the line in our documentation and update the url to the new repo :)
Of course. I was just hoping to save someone the head-scratching that I just experienced. This PR doesn't really help given that
Oh... well... darn. I guess we are in some kind of valley between fastify-apollo and apollo-server-fastify.
@delvedor I think that's fine as long as there is an explanatory note. It would be confusing if the link text says you're going one place and then the link goes to another. However, given Mateo's note, things are a little more complicated than I understood them to be. We may as well close this rather than leave it open indefinitely. |
|
@dtex what I mean is, instead of removing the line, just update it with the new plugin :) |
|
@delvedor Oh, gotchya. Yes, once it goes live that is the right thing to do. |
|
Hi, @dtex and all!
I was one of those people that stumbled upon the For my understanding, there is a PR in flight to create a I look forward to hearing back! -Manny |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Just an update. There is a new PR for the support we need in Apollo: |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
What's the status on this? |
|
Since the release of [email protected], fastify support has officially landed (related PR: apollographql/apollo-server#2280) I think this PR just needs an update to reference the official package (by pointing to this link : https://github.com/apollographql/apollo-server/tree/master/packages/apollo-server-fastify and referencing the package as Edit: there is a related PR running here : #1156 |
|
@darkgl0w would you like to open a new pr with the correct link? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As of this PR, fastify-apollo is no longer a standalone module and the repo has been archived.
@nfishe Can you add a note on your repo also? It would be helpful for anyone who stumbles across it.
Checklist
npm run testandnpm run benchmark