Skip to content

Rename ContentTypeParser#1123

Merged
mcollina merged 1 commit intofastify:masterfrom
cemremengu:rename-ContentTypeParser
Sep 4, 2018
Merged

Rename ContentTypeParser#1123
mcollina merged 1 commit intofastify:masterfrom
cemremengu:rename-ContentTypeParser

Conversation

@cemremengu
Copy link
Copy Markdown
Contributor

Checklist

  • run npm run test
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another file is requiring that, so you might have to change that one as well.

@cemremengu cemremengu force-pushed the rename-ContentTypeParser branch from 45ca9a1 to 6b57a8c Compare August 30, 2018 13:40
@cemremengu
Copy link
Copy Markdown
Contributor Author

This may conflict with #1122. Not sure which one should be merged first.

@mcollina
Copy link
Copy Markdown
Member

Merged the wrong one, could you resolve the conflict?

@cemremengu cemremengu force-pushed the rename-ContentTypeParser branch from 6b57a8c to 85b6271 Compare August 30, 2018 16:00
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit cce1a85 into fastify:master Sep 4, 2018
@cemremengu cemremengu deleted the rename-ContentTypeParser branch September 4, 2018 08:53
@delvedor delvedor added the internals Change that won't impact the surface API. label Sep 4, 2018
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

internals Change that won't impact the surface API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants