Conversation
…y into SkeLLLa-feature/trust-proxy
Member
Author
|
This does not include any performance regression. |
delvedor
reviewed
Aug 21, 2018
|
|
||
| req.id = genReqId(req) | ||
| handleTrustProxy(req) | ||
| req.hostname = req.hostname || req.headers['host'] |
Member
There was a problem hiding this comment.
I think we should add ip and hostname directly to our request and reply object.
Maybe we can do that in the next branch.
delvedor
added
feature
documentation
21 tasks
4 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1055
Fixes #1044
Checklist
npm run testandnpm run benchmark