build(deps-dev): replace eslint-plugin-node with eslint-plugin-n#98
Merged
build(deps-dev): replace eslint-plugin-node with eslint-plugin-n#98
Conversation
Contributor
|
Does it work without touching the eslint config? |
Member
Author
Ah fudge, missed that. |
Contributor
|
I am just curios why it is not erroring when linting. Maybe the plugin gets not required at all? |
Member
ESLint always try his best to lint even if their are something wrong with the setting. Replace to |
Member
Author
Sorted in 603b708 |
Uzlopak
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint-plugin-nodeis no longer maintained.Main repo migrated a while back:
https://github.com/fastify/fastify/blob/67bee117a7c5c6dad503f656204e49cf329a37af/package.json#L144
Checklist
and the Code of conduct