Merged
Conversation
added 2 commits
April 18, 2024 15:31
…ds the 100% test coverage goal
Uzlopak
requested changes
Apr 19, 2024
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
basename.test.js should cover all branches
busboy-emit.test.js should check if the first call to busboy.emit('finish') returns anything
dicer-write.test.js does not test what it claims
Contributor
Author
@Uzlopak am I reading the code wrong, or |
Uzlopak
reviewed
Apr 19, 2024
test/dicer-write.test.js
Outdated
| }) | ||
| }) | ||
|
|
||
| t.end() |
Contributor
There was a problem hiding this comment.
Basically not testing anything, because you call t.end(). use t.plan for this subtest also.
Contributor
Author
There was a problem hiding this comment.
@Uzlopak oh, good to know! First time using this testing framework!
Contributor
Author
There was a problem hiding this comment.
@Uzlopak is there anything else for me to do in this PR?
Uzlopak
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more automated tests, chipping in for the 100% test coverage goal mentioned in here
I really don't know the project, if not for what I studied while writing tests, so I picked the least complicated route and wrote a couple of automated tests of "well exposed" functions and methods