Skip to content

fix: dont use undocumented(?) internal _events attribute#146

Merged
mcollina merged 1 commit intomasterfrom
avoid-_event
Feb 28, 2024
Merged

fix: dont use undocumented(?) internal _events attribute#146
mcollina merged 1 commit intomasterfrom
avoid-_event

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Feb 28, 2024

@Uzlopak Uzlopak changed the title fix: dont use internal _events attribute fix: dont use undocumented(?) internal _events attribute Feb 28, 2024
Copy link
Copy Markdown
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 501f7d6 into master Feb 28, 2024
@mcollina mcollina deleted the avoid-_event branch February 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants