fix /permissive- flag causing a compile error on clang for windows#305
Merged
lemire merged 2 commits intofastfloat:mainfrom Mar 9, 2025
Merged
fix /permissive- flag causing a compile error on clang for windows#305lemire merged 2 commits intofastfloat:mainfrom
lemire merged 2 commits intofastfloat:mainfrom
Conversation
lemire
reviewed
Feb 26, 2025
Member
|
Running tests. |
Member
|
This will be part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the library with Clang on Windows (not clang-cl and not MSYS2), an error is thrown by the compiler:
This is caused by these lines in
CMakeLists.txt:Clang on Windows defines
MSVC_VERSION, but does not support MSVC-like compiler flags. This PR adds an extra check to make sure the flag is only added when the used compiler supports it.Presumably fixes #304, although it seems that CI only has MSYS2 Clang and MSVC Clang-cl workflows, neither of which are impacted by this issue, so I've only verified that it works on my machine.