Show brand of Xserver in WM section #1888
Conversation
|
What does it print on original X11? |
| ffStrbufInit(&result.wmProtocolName); | ||
| ffStrbufInit(&result.deProcessName); | ||
| ffStrbufInit(&result.dePrettyName); | ||
| ffStrbufInit(&result.serverVendor); |
There was a problem hiding this comment.
So this is only used for X11. I think it should be ok to append the string to wmProtocolName. Like X11-XLibre
There was a problem hiding this comment.
I think differentiating between the protocol and the implementation detail is important (as it's done for fonts already), even if it means allocating a few more bytes.
There was a problem hiding this comment.
- Most, if not all, distros still use the original X11 impl by default. So syou get
The X.Org Foundationin most cases. - More and more distros are moving to Wayland. For Wayland it's not used at all.
I still think a separate field is not necessary. I'd like to implement this:
- If
xcb_setup_vendorreportsThe X.Org Foundation, set protocol name toX11 - Otherwise, set protocol name to whatever
xcb_setup_vendorreports ( in your case,XLibre)
There was a problem hiding this comment.
I really should've tested this on Xorg before submitting, I assumed the vendor string to be "Xorg". Sorry about that.
What do you think about WM: KWin (X11) [Xorg] and WM: KWin (X11) [XLibre]? Or maybe WM: KWin (X11/Xorg) and WM: KWin (X11/XLibre) ?
There was a problem hiding this comment.
I prefer WM: KWin (X11) and WM: KWin (XLibre), so if a user uses the original X11 nothing changes.
| void* replyValue = malloc((size_t)length + 1); | ||
| memcpy(replyValue, data->ffxcb_setup_vendor(setup), (size_t) length); | ||
| ((char*) replyValue)[length] = '\0'; | ||
|
|
||
| if (ffStrSet(replyValue)) | ||
| ffStrbufSetS(&result->serverVendor, replyValue); | ||
|
|
||
| free(replyValue); |
There was a problem hiding this comment.
ffStrbufSetNS(&result->serverVendor, (uint32_t) length, data->ffxcb_setup_vendor(setup))
I will do this change myself. |
2 participants
Putting it in square brackets next to the WM seemed like the most logical choice after looking at how icon and font information is displayed. If you want any changes made, just tell me and I'll take care of it.