Fix: detect agents installed via version managers (nvm, mise, etc.)#11
Merged
Merged
Conversation
Daemon processes don't source shell profiles (.zshrc/.bashrc), so exec.LookPath fails for binaries installed via nvm, mise, etc. Add lookPath() that falls back to a login interactive shell (zsh -lic which) when the standard PATH lookup fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Problem
Daemon processes don't source shell profiles (
.zshrc/.bashrc), soexec.LookPathfails for binaries installed via version managers like nvm, mise, etc. This causesDetectAndConfigureto missclaudeeven when it's installed — on a fresh/empty config, the agent is never detected.Root Cause
exec.LookPathonly searches the current process'sPATH. When weclaw runs as a daemon (Setsid: true), thePATHdoesn't include nvm's bin directory (e.g.~/.nvm/versions/node/v24.11.1/bin/), because those paths are added in.zshrcwhich is only sourced for interactive shells.Solution
Add a
lookPath()helper that falls back to resolving via a login interactive shell (zsh -lic which <binary>) when the standardexec.LookPathfails. The-liflags ensure.zshrc/.bashrcare sourced, picking up version manager paths.Test Plan
Added
config/detect_test.gowith 4 test cases:exec.LookPathfails butlookPathsucceeds via login shell