✅ Add __init__.py files to fix test suite#809
Merged
tiangolo merged 2 commits intofastapi:masterfrom May 2, 2024
Merged
Conversation
Contributor
|
📝 Docs preview for commit dd8d5f1 at: https://c732f7a3.typertiangolo.pages.dev |
svlandeg
changed the title
__init__.py to fix test suite locally
Member
Author
In fact, perhaps we should consider extending the test suite to run on a grid, including |
svlandeg
changed the title
__init__.py to fix test suite locally__init__.py files to fix test suite
tiangolo
changed the title
__init__.py files to fix test suite__init__.py files to fix test suite
Member
|
Awesome! 🚀 Yes, it would be great to run tests on Windows and MacOS, would you like to add that? 🙏 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the test suite locally (both from the IDE as from Git Bash on Windows), I get a failure on
tests/test_tutorial/test_subcommands/both fortest_tutorial001.pyas well astest_tutorial003.pybecause theimport itemsstatement fails. The reason why it fails is because a__init__.pyfile is missing in the originaldocs_srcmodule. Even though the CI here doesn't seem to be impacted, I think we might as well add the proper__init__.pyfiles.