🐛 Fix sourcing of completion path for Git Bash#801
Merged
tiangolo merged 5 commits intofastapi:masterfrom Aug 24, 2024
Merged
Conversation
svlandeg
added
bug
svlandeg
commented
Apr 19, 2024
4 tasks
svlandeg
added
shell / bash
and removed
autocompletion
repo / install
Member
|
Awesome, thank you @svlandeg! 🙇 I just tested it here on bash under Docker and it's all working. This will be available in Typer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My system
When running
on my Windows system with Git Bash, Typer fetches
Path.home()which isC:\Users\Sofie. This is correct in itself, but Git Bash can't work directly with paths that contain backslashes. After installation,.bashrccontainsand after rebooting the terminal, it will complain:
To get this to work with Git Bash,
.bashrcshould instead containand then it works - no error upon starting the console, and the completion feature works.
TODO
This PR needs to be carefully checked on a "normal" Bash system to double check that the single quote doesn't harm any other environments. I wouldn't think so, but I'm not 100% sure.