Skip to content

📝 Update package docs with the latest versions of Typer and Poetry#781

Merged
tiangolo merged 8 commits intofastapi:masterfrom
kinuax:update-package-section
Aug 24, 2024
Merged

📝 Update package docs with the latest versions of Typer and Poetry#781
tiangolo merged 8 commits intofastapi:masterfrom
kinuax:update-package-section

Conversation

@kinuax
Copy link
Copy Markdown
Contributor

@kinuax kinuax commented Mar 30, 2024

I have followed the package section (Building a Package) and I would propose to update:
-current Poetry dependencies and behavior
-current Typer dependencies and behavior
-current pip behavior
-recent typer command changes
-example user rick harmonization

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@svlandeg svlandeg added docs Improvements or additions to documentation p3 labels Apr 2, 2024
Comment thread docs/tutorial/package.md
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2024

Copy link
Copy Markdown
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @kinuax! I revised the changes while running through the docs on my system as well, and I can confirm that almost all of your edits accurately reflect the current output and behaviour of poetry and typer. Thanks for going through all of this so carefully!

The only thing that is different on my system and with Typer 0.12.3, are the installed libraries. Could you double check how this looks on your end with the latest Typer? I know there's been some changes in the recent Typer versions, so it's likely that this has changed since you made this PR originally.

Comment thread docs/tutorial/package.md Outdated
Comment thread docs/tutorial/package.md
@github-actions
Copy link
Copy Markdown
Contributor

@kinuax kinuax force-pushed the update-package-section branch from ae06c64 to f9d3546 Compare April 19, 2024 13:23
@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and should be ready for merge after a final review by Tiangolo!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2024

@tiangolo tiangolo changed the title 📝 Update package section 📝 Update package docs with the latest versions of Typer and Poetry Aug 24, 2024
@tiangolo
Copy link
Copy Markdown
Member

Great, thank you @kinuax! 🚀

And thank you @svlandeg for the careful review. 🙇

@tiangolo tiangolo merged commit 1da8e86 into fastapi:master Aug 24, 2024
@kinuax kinuax deleted the update-package-section branch August 24, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation p3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants