🚸 Improve assertion error message if a group is not a valid subclass#425
Merged
tiangolo merged 4 commits intofastapi:masterfrom Aug 24, 2024
Merged
🚸 Improve assertion error message if a group is not a valid subclass#425tiangolo merged 4 commits intofastapi:masterfrom
tiangolo merged 4 commits intofastapi:masterfrom
Conversation
Contributor
svlandeg
approved these changes
Apr 18, 2024
Member
svlandeg
left a comment
There was a problem hiding this comment.
It's a good idea to add this message to help developers with debugging. Thanks for your contribution!
Member
|
Nice, thank you @chrisburr! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest typer release my CI (which runs a
typerbased script) started failing with:The cause turned out to be:
https://github.com/tiangolo/typer/blob/fac64ca03e9fda619710702c3364e233e0e644ac/typer/main.py#L505
which was triggered by my script contianing:
The fix is easy and just requires replacing
click.Groupwithtyper.core.TyperGrouphowever I think the assertion error should be made this clearer.