Skip to content

👷 Run tests with lower bound uv sync, update minimum dependencies#1526

Merged
tiangolo merged 10 commits intomasterfrom
lower-bound
Feb 16, 2026
Merged

👷 Run tests with lower bound uv sync, update minimum dependencies#1526
tiangolo merged 10 commits intomasterfrom
lower-bound

Conversation

@YuriiMotov
Copy link
Member

@YuriiMotov YuriiMotov commented Feb 10, 2026

👷 Run tests with lower bound uv sync (as it's done in FastAPI repo)

Upgrade lower bound versions for:

  • "click >= 8.2.1"
  • "rich >=12.3.0"

And test dependencies:

  • "pytest>=7.4.0,<9.0.0"
  • "pytest-cov>=4.0.0,<8.0.0"
  • "pytest-sugar>=0.9.5,<1.2.0"

Reasons are explained in the comments


Tests for windows-latest, 3.12, lowest-direct take really long:

Test / test (windows-latest, 3.12, lowest-direct) (pull_request) Successful in 8m

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

@github-actions github-actions bot added the conflicts Automatically generated when a PR has a merge conflict label Feb 10, 2026
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added conflicts Automatically generated when a PR has a merge conflict and removed conflicts Automatically generated when a PR has a merge conflict labels Feb 10, 2026
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot removed the conflicts Automatically generated when a PR has a merge conflict label Feb 10, 2026
Comment on lines +83 to +85
"pytest >=7.4.0",
"pytest-cov >=4.0.0",
"pytest-sugar >=0.9.5",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With lower versions of pytest it fails on Windows with:

DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead

With lower versions of pytest-cov it fails with:

pytest.PytestDeprecationWarning: The hookimpl CovPlugin.pytest_configure_node uses old-style configuration options (marks or attributes).

With lower version of pytest-sugar it fails on Windows with:

INTERNALERROR>   File "D:\a\typer\typer\.venv\Lib\site-packages\pytest_sugar.py", line 168, in pytest_configure
INTERNALERROR>     from distutils.version import LooseVersion
INTERNALERROR> ModuleNotFoundError: No module named 'distutils'

@github-actions github-actions bot added the conflicts Automatically generated when a PR has a merge conflict label Feb 10, 2026
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added conflicts Automatically generated when a PR has a merge conflict and removed conflicts Automatically generated when a PR has a merge conflict labels Feb 11, 2026
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot removed the conflicts Automatically generated when a PR has a merge conflict label Feb 11, 2026
"click >= 8.2.1",
"shellingham >=1.3.0",
"rich >=10.11.0",
"rich >=12.3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With lower versions of rich it fails with:

FAILED tests/test_tutorial/test_exceptions/test_tutorial003.py::test_traceback_rich_pretty_short_disable - assert 'app()' in '╭───────────────────── Traceback (most recent call last) ──────────────────────╮\n│

Comment on lines +37 to +38
"click >= 8.0.0; python_version < '3.10'",
"click >= 8.2.1; python_version >= '3.10'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With lower versions of click it fails with:

FAILED tests/test_cli/test_sub_completion.py::test_script_completion_run - AssertionError: assert '--name' in '--help\n'

And, Python 3.9 needs click version less than 8.2.0

@YuriiMotov YuriiMotov marked this pull request as ready for review February 11, 2026 17:22
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you @YuriiMotov! 🙌

@tiangolo tiangolo merged commit 459030e into master Feb 16, 2026
24 checks passed
@tiangolo tiangolo deleted the lower-bound branch February 16, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants