👷 Run tests with lower bound uv sync, update minimum dependencies#1526
Merged
👷 Run tests with lower bound uv sync, update minimum dependencies#1526
Conversation
Contributor
📝 Docs previewLast commit 41e71d2 at: https://b555917b.typertiangolo.pages.dev |
b24972a to
8447ba5
Compare
YuriiMotov
commented
Feb 10, 2026
… module named 'distutils'`
YuriiMotov
commented
Feb 10, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
f2209cf to
55afe9f
Compare
YuriiMotov
commented
Feb 10, 2026
Comment on lines
+83
to
+85
| "pytest >=7.4.0", | ||
| "pytest-cov >=4.0.0", | ||
| "pytest-sugar >=0.9.5", |
Member
Author
There was a problem hiding this comment.
With lower versions of pytest it fails on Windows with:
DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead
With lower versions of pytest-cov it fails with:
pytest.PytestDeprecationWarning: The hookimpl CovPlugin.pytest_configure_node uses old-style configuration options (marks or attributes).
With lower version of pytest-sugar it fails on Windows with:
INTERNALERROR> File "D:\a\typer\typer\.venv\Lib\site-packages\pytest_sugar.py", line 168, in pytest_configure
INTERNALERROR> from distutils.version import LooseVersion
INTERNALERROR> ModuleNotFoundError: No module named 'distutils'
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
YuriiMotov
commented
Feb 11, 2026
| "click >= 8.2.1", | ||
| "shellingham >=1.3.0", | ||
| "rich >=10.11.0", | ||
| "rich >=12.3.0", |
Member
Author
There was a problem hiding this comment.
With lower versions of rich it fails with:
FAILED tests/test_tutorial/test_exceptions/test_tutorial003.py::test_traceback_rich_pretty_short_disable - assert 'app()' in '╭───────────────────── Traceback (most recent call last) ──────────────────────╮\n│
bbc1cdf to
41e71d2
Compare
YuriiMotov
commented
Feb 11, 2026
Comment on lines
+37
to
+38
| "click >= 8.0.0; python_version < '3.10'", | ||
| "click >= 8.2.1; python_version >= '3.10'", |
Member
Author
There was a problem hiding this comment.
With lower versions of click it fails with:
FAILED tests/test_cli/test_sub_completion.py::test_script_completion_run - AssertionError: assert '--name' in '--help\n'
And, Python 3.9 needs click version less than 8.2.0
tiangolo
approved these changes
Feb 16, 2026
Member
tiangolo
left a comment
There was a problem hiding this comment.
Excellent, thank you @YuriiMotov! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👷 Run tests with lower bound uv sync (as it's done in FastAPI repo)
Upgrade lower bound versions for:
And test dependencies:
Reasons are explained in the comments
Tests for
windows-latest, 3.12, lowest-directtake really long: