✅ Add missing tests for code examples#1465
Merged
Conversation
Contributor
📝 Docs previewLast commit 393f99f at: https://e46d34b1.typertiangolo.pages.dev Modified Pages |
YuriiMotov
force-pushed
the
add-missing-tests-for-code-examples
branch
5 times, most recently
from
d55a383 to
3606b3d
Compare
YuriiMotov
commented
Dec 29, 2025
tests/test_tutorial/test_options/test_version/test_tutorial002.py
Outdated
Show resolved
Hide resolved
YuriiMotov
force-pushed
the
add-missing-tests-for-code-examples
branch
from
3606b3d to
8add382
Compare
YuriiMotov
commented
Dec 30, 2025
Comment on lines
+15
to
+23
| @pytest.mark.xfail( | ||
| condition=((platform.system() == "Windows") and (sys.version_info < (3, 10))), | ||
| reason="On Windows with Python 3.9, output is in stdout instead of stderr", | ||
| ) | ||
| def test_cli(): | ||
| result = runner.invoke(app) | ||
| assert result.exit_code == 0 | ||
| assert result.stdout == "" | ||
| assert "Here is something written to standard error" in result.stderr |
Member
Author
There was a problem hiding this comment.
Is this a known issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are some missing tests for code examples:
typer/pyproject.toml
Lines 133 to 160 in da9c4c6
This PR adds missing tests to improve coverage