📌 Pin Click to < 8.2, compatibility for Click >= 8.2 will be added in a future version#1225
Conversation
Contributor
|
📝 Docs preview for commit 648012f at: https://b3f2f168.typertiangolo.pages.dev |
botimer
added a commit
to mlibrary/dor-py
that referenced
this pull request
May 19, 2025
There is a subtle dependency problem with click 8.2 that causes the packaged binary to fail. Typer 0.15.4 was released to limit that dependency range and resolve it. There are no other package changes here. We also set the help flag by default since the top-level and two sub-commands in place have no default behavior. Because the app will be packaged rather than run with python <whatever.py>, we also add the callback decorator and remove the __main__ check. This is replaced by the `dor` binary that poetry installs. See also: - https://typer.tiangolo.com/tutorial/package/#create-your-app - fastapi/typer#1225
kiryazovi-redis
added a commit
to redis-developer/cae-re-env0
that referenced
this pull request
May 20, 2025
uglide
added a commit
to redis-developer/cae-re-env0
that referenced
this pull request
May 20, 2025
fix: pin click to <8.2.0 to fix typer compatibility (fastapi/typer#1225)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility for Click >= 8.2 is worked on here: #1222 , but there are a couple of unsolved issues there still.
So this pin will solve current apps for now, and a future release will have compatibility with the latest Click.