✨ Allow custom styles for commands in help output#1103
Merged
tiangolo merged 2 commits intofastapi:masterfrom Feb 27, 2025
Merged
✨ Allow custom styles for commands in help output#1103tiangolo merged 2 commits intofastapi:masterfrom
tiangolo merged 2 commits intofastapi:masterfrom
Conversation
svlandeg
changed the title
svlandeg
reviewed
Jan 2, 2025
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Good catch - that style shouldn't be hardcoded like this.
We could indeed reuse STYLE_OPTION as you propose, but that would mean that the color of this first column would always be the same as the style chosen for the console's "option" theme. I think these may also be separate things?
So basically I think we could take this one step further and define a new var, something like STYLE_COMMANDS_TABLE_FIRST_COLUMN and set that to "bold cyan" to default? What do you think?
Contributor
Author
|
Sounds good @svlandeg, I made the change. |
svlandeg
approved these changes
Jan 3, 2025
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Look good to me! I'll leave this for Tiangolo to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small tweak to the command highlighting in help output to use the global
STYLE_OPTIONinstead of being hardcoded asbold cyan:This allows users to more easily customize colors in their help output.
By default, this has no effect since the default
STYLE_OPTIONis alreadybold cyan.