✏️ Fix a few typos in the source and documentation#1028
✏️ Fix a few typos in the source and documentation#1028tiangolo merged 3 commits intofastapi:masterfrom
Conversation
|
📝 Docs preview for commit ed7c0cb at: https://1783ccf2.typertiangolo.pages.dev Modified Pages |
svlandeg
changed the title
There was a problem hiding this comment.
Hi, thanks for the contribution! We appreciate it.
The typo fixes in the documentation and source comments look fine. 👍
However, I would refrain from changing convertor to converter as this is used as an argument in various public functions in main.py, and it would break people's code who call these functions with convertor=x. And while convertor is probably less frequently used than converter, I still think it's a valid term, so as such I would just keep that one across all occurrences. Can you make that edit? Thanks! 🙏
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
I've gone ahead and reverted the convertor changes, to avoid unnecessary breaking changes. This PR should now be good to merge 🎉
|
📝 Docs preview for commit b56069c at: https://68bdccf5.typertiangolo.pages.dev Modified Pages |
3 participants
This merge request fixes typos in various locations in the application.