small refactor

svlandeg · svlandeg · commit b482a50c4b22 · 2025-11-17T14:16:28.000+01:00
diff --git a/typer/core.py b/typer/core.py
@@ -384,7 +384,7 @@ def make_metavar(self, ctx: Union[click.Context, None] = None) -> str:
         if self.metavar is not None:
             var = self.metavar
             if not self.required and not var.startswith("["):
-                return f"[{var}]"
+                var = f"[{var}]"
             return var
         var = (self.name or "").upper()
         if not self.required:
