Skip to content

🌐 Add German translation for docs/de/docs/tutorial/first-steps.md#9530

Merged
tiangolo merged 21 commits intofastapi:masterfrom
fhabers21:language/tutorial-first-steps-de
Jan 9, 2024
Merged

🌐 Add German translation for docs/de/docs/tutorial/first-steps.md#9530
tiangolo merged 21 commits intofastapi:masterfrom
fhabers21:language/tutorial-first-steps-de

Conversation

@fhabers21
Copy link
Contributor

add german translation for tutorial/first-steps.md

@github-actions
Copy link
Contributor

@tiangolo tiangolo changed the title 🌐 Add german translation for docs/de/docs/tutorial/first-steps.md 🌐 Add German translation for docs/de/docs/tutorial/first-steps.md Jun 3, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-de German translations labels Jun 3, 2023
@tiangolo
Copy link
Member

Copy link

@creyD creyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comments I had, I liked the translation.

@creyD
Copy link

creyD commented Aug 31, 2023

@tiangolo Would it be possible to adjust the docs so that the reader already knows that the article will be in another language than the selected one? Here i.e. there is no translated version yet for the section, so the reader will automatically be redirected to the English one, which is fine, just would be nice to have indication beforehand.
Screenshot 2023-08-31 at 16 19 40

@fhabers21
Copy link
Contributor Author

@creyD Thank you for your valuable feedback. I corrected the points you mentioned.

@tiangolo
Copy link
Member

Copy link

@creyD creyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments, I believe it is good to go now!

@tiangolo
Copy link
Member

tiangolo commented Sep 2, 2023

nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Sep 20, 2023
* Full translation
* Based on fastapi#9530
* In sync with current en/docs/tutorial/first-steps.md
* Hand-translated (Google translate rarely used)
* Checked for errors using LanguageTool
* Manually checked
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Sep 20, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Sep 20, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Oct 5, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Oct 5, 2023
@nilslindemann
Copy link
Contributor

Hello @fhabers21, good PR, I approved it.

Could you include the suggestions in the following .md?

first-steps.md

These are mostly changes suggested by GeorchW, who approved my other closed PR. Then he could approve this PR here too (ping, @GeorchW), and we can get this merged. 🚀

nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
@fhabers21
Copy link
Contributor Author

@nilslindemann, @GeorchW, big thanks for your valuable feedback. I've included your suggestions.

@tiangolo, we might be good to go.

@tiangolo
Copy link
Member

@nilslindemann
Copy link
Contributor

Superklasse! Kann meines Erachtens gemerged werden. Nur noch die eine Stelle, wo die „typografischen“ fehlen.

@fhabers21
Copy link
Contributor Author

fhabers21 commented Nov 12, 2023

@nilslindemann danke für deinen erneuten Review! Habe die Stelle ausgebessert.

@tiangolo
Copy link
Member

@nilslindemann
Copy link
Contributor

Ich hab noch eine Kleinigkeit entdeckt: In Zeile 46 könnte man JSON-Response statt JSON-Antwort schreiben. Ist aber "Geschmäckle" :-)

@tiangolo
Copy link
Member

tiangolo commented Jan 9, 2024

Nice, thank you @fhabers21! 🚀

And thanks for the reviews @nilslindemann, @GeorchW, @creyD 🙇

@tiangolo tiangolo merged commit 031000f into fastapi:master Jan 9, 2024
@fhabers21 fhabers21 deleted the language/tutorial-first-steps-de branch January 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-de German translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants