🌐 Add Korean translation for docs/ko/docs/benchmarks.md and docs/ko/docs/tutorial/testing.md#9496
Closed
ElliottLarsen wants to merge 8 commits intofastapi:masterfrom
Closed
🌐 Add Korean translation for docs/ko/docs/benchmarks.md and docs/ko/docs/tutorial/testing.md#9496ElliottLarsen wants to merge 8 commits intofastapi:masterfrom
docs/ko/docs/benchmarks.md and docs/ko/docs/tutorial/testing.md#9496ElliottLarsen wants to merge 8 commits intofastapi:masterfrom
Conversation
Contributor
tiangolo
changed the title
docs/ko/docs/tutorial/testing.mddocs/ko/docs/tutorial/testing.md
Contributor
Contributor
Merge from FastAPI Master
Contributor
Member
tiangolo
changed the title
docs/ko/docs/tutorial/testing.mddocs/ko/docs/benchmarks.md and docs/ko/docs/tutorial/testing.md
Contributor
|
Thanks for your work. I'm not sure about two document changes at one PR. I think it would be seperated. |
Contributor
|
You have to separate it. Close the PR and open it again 😿 |
Member
|
It would be better to do this in 2 PRs, that way others would be able to review and approve one file and I could merge it. We could do that and continue gradually. 🤓 For now, I'll close this one. But feel free to create 2 new PRs (or anyone else that sees this, feel free to copy the contents and start a new PR with it, or start over, as the original might have changed a bit). ☕ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Korean translation for
docs/ko/docs/tutorial/testing.mdRelated to
Korean translations#2017