Skip to content

🌐 Add setup for translations to Lao#9396

Merged
tiangolo merged 24 commits intofastapi:masterfrom
TheBrown:master
May 8, 2023
Merged

🌐 Add setup for translations to Lao#9396
tiangolo merged 24 commits intofastapi:masterfrom
TheBrown:master

Conversation

@TheBrown
Copy link
Contributor

About Laos: Laos is a landlocked country in South-east Asia on the Indochinese peninsula between Thailand and Vietnam and north of Cambodia.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@TheBrown TheBrown closed this Apr 19, 2023
@TheBrown TheBrown reopened this Apr 19, 2023
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@tiangolo tiangolo changed the title Add a new language, Lao. 🌐 Add setup for translations to Lao Apr 25, 2023
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm asking you to remove a few files for translations, those should go in independent PRs, that way others can review and approve or ask for changes one by one.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@TheBrown
Copy link
Contributor Author

TheBrown commented Apr 26, 2023

Hi @tiangolo Thank you for your suggestion. I have resolved all changes requested.

@github-actions
Copy link
Contributor

@TheBrown
Copy link
Contributor Author

Is the current file update ok? @tiangolo

@tiangolo tiangolo added lang-all Translations lang-lo Lao translations labels May 4, 2023
@tiangolo
Copy link
Member

tiangolo commented May 8, 2023

Great, thank you @TheBrown! 🚀

@tiangolo tiangolo merged commit ed1f93f into fastapi:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang-all Translations lang-lo Lao translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants