🎨 Fix types for lifespan, upgrade Starlette to 0.26.1#9245
Merged
Conversation
Contributor
Contributor
Closed
9 tasks
Contributor
|
You also need to add |
Member
Author
|
Good point, thanks @adriangb! Trying it locally I realized I had to redefine |
Contributor
|
Hmm I’m surprised the |
Contributor
Member
Author
|
I'm trying with this example: from collections.abc import AsyncGenerator
from contextlib import asynccontextmanager
from fastapi import FastAPI
@asynccontextmanager
async def lifespan(_: FastAPI) -> AsyncGenerator[None, None]:
...
yield
...
app = FastAPI(lifespan=lifespan)And I get this error: ...I guess it would be fine for external things to have |
Contributor
Member
Author
|
Ah, yeah, the error is not in the lifespan, but that the class doesn't have the custom attributes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎨 Fix types for lifespan, depends on Kludex/starlette#2077